Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix for failing get_video_info api #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

markdegrootnl
Copy link

As described in 0xced/XCDYouTubeKit#534 Youtube seems to have changed the get_video_info api endpoint. This has not been fixed in XCDYouTubeKit yet, so this hotfix references another XCDYouTubeKit version.

@markdegrootnl
Copy link
Author

I've updated the XCDYoutubeKit according to 0xced/XCDYouTubeKit#548 and added some code to use the YouTubeDataApiKey preference for iOS as well.

@Sampath-Lokuge
Copy link

Sampath-Lokuge commented Jan 17, 2022

Hi, When will have this version available?

@TiagoAndreAlmeida
Copy link

hi, any update about this pull request ?

@Sampath-Lokuge
Copy link

@YaroslavG
Copy link

YaroslavG commented Mar 17, 2022

markdegrootnl

Thank for your work. Could you suggest how best to include these changes in my project if I use Ionic Appflow ?
How to include your PR in package.json ?

@markdegrootnl
Copy link
Author

You can add this PR in your project using
cordova plugin add https://github.com/blackcupnl/CordovaYoutubeVideoPlayer.git#hotfix/get_video_info

@vrdriver
Copy link

vrdriver commented Apr 24, 2022

Hi @markdegrootnl, While your solution worked, is there any reason why it would be slower to load on iOS than Android? It's almost instant on Android, yet take a long while in iOS. I mean, it's certainly better than it not working, but just curious if there was a tweak I've missed? EG. Is it just me? ta.


Update: I found a solution in the end: https://stephenmonro.wordpress.com/2022/04/13/getting-youtube-videos-to-play-again-in-ionic5/

@markdegrootnl
Copy link
Author

Great work @vrdriver. Submit a PR to this repo and hopefully it will get merged sometime...

@YaroslavG
Copy link

YaroslavG commented Jun 23, 2022

EG. Is it just me?

Update: I found a solution in the end: https://stephenmonro.wordpress.com/2022/04/13/getting-youtube-videos-to-play-again-in-ionic5/

@vrdriver I have the same issue with slower to load video on iOS. Thanks for sharing the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants